Attention is currently required from: Patrick Rudolph, Shuo Liu.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80090?usp=email )
Change subject: device/device_util: Add method to retrieve the domain
......................................................................
Patch Set 2: Code-Review+1
(1 comment)
Patchset:
PS2:
It is still hard to tell why what pointers are checked for NULL. If something
isn't supposed to be NULL, I prefer assertions.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/80090?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I0068b82e139fe7a35e6b1b91b7d386b750c80748
Gerrit-Change-Number: 80090
Gerrit-PatchSet: 2
Gerrit-Owner: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Shuo Liu
shuo.liu@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Attention: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Attention: Shuo Liu
shuo.liu@intel.com
Gerrit-Comment-Date: Tue, 23 Jan 2024 12:33:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment