Attention is currently required from: Tarun Tuli, Subrata Banik, Kapil Porwal, Sumeet R Pawnikar.
Eric Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74379 )
Change subject: mb/google/rex/baseboard/rex: Add cpu power limits ......................................................................
Patch Set 1:
(2 comments)
File src/mainboard/google/rex/variants/baseboard/rex/ramstage.c:
https://review.coreboot.org/c/coreboot/+/74379/comment/b740352f_7d95c250 PS1, Line 15: void variant_update_power_limits(const struct cpu_power_limits *limits, size_t num_entries) this section can be part of power_limit.c. this is the same code like ADL one...
File src/mainboard/google/rex/variants/rex0/ramstage.c:
https://review.coreboot.org/c/coreboot/+/74379/comment/b78adc39_b613549e PS1, Line 17: variant_update_power_limits we can call this directly from systemagent.c. no need hook up from variant_devtree_update. like mb_update_power_limits in systemagent.c or call variant_update_power_limits directly.