Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45096 )
Change subject: vc/amd/fsp/picasso: Update to UPD 1.0.1.3
......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/c/coreboot/+/45096/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/45096/1//COMMIT_MSG@8
PS1, Line 8:
Please summarize the changes in the commit message.
Done
https://review.coreboot.org/c/coreboot/+/45096/1/src/vendorcode/amd/fsp/pica...
File src/vendorcode/amd/fsp/picasso/FspsUpd.h:
https://review.coreboot.org/c/coreboot/+/45096/1/src/vendorcode/amd/fsp/pica...
PS1, Line 35: /** Offset 0x0123**/ uint8_t xhci_sparse_mode_enable;
: /** Offset 0x0124**/ uint8_t UnusedUpdSpace0[44];
these should go away due to CB:45113 once you rebase.
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/45096
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic5caff594157e03d792b999ca60274cf53c708e2
Gerrit-Change-Number: 45096
Gerrit-PatchSet: 2
Gerrit-Owner: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Aaron Durbin
adurbin@chromium.org
Gerrit-CC: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 23 Sep 2020 19:41:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Marshall Dawson
marshalldawson3rd@gmail.com
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-MessageType: comment