19 Sep
2024
19 Sep
'24
12:05 p.m.
Attention is currently required from: Martin L Roth, Nicholas Chin.
Nico Huber has posted comments on this change by Nicholas Chin. ( https://review.coreboot.org/c/coreboot/+/84386?usp=email )
Change subject: Makefile: Allow defining order-only prerequisites in create_cc_template ......................................................................
Patch Set 2: Code-Review+1
(1 comment)
File Makefile:
https://review.coreboot.org/c/coreboot/+/84386/comment/6b20d930_4054580e?usp... : PS2, Line 420: generated Only the name is somewhat bugging me, e.g. for `$(ramstage-c-generated)` I would expect this to contain generated C files, not files generated as a dependency for C files.
How about `-generated-deps`? `-gen-deps`?
--
To view, visit https://review.coreboot.org/c/coreboot/+/84386?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I50d87b3d9012967eefb197be12b2e0f096b0b67c
Gerrit-Change-Number: 84386
Gerrit-PatchSet: 2
Gerrit-Owner: Nicholas Chin nic.c3.14@gmail.com
Gerrit-Reviewer: Martin L Roth gaumless@gmail.com
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Martin L Roth gaumless@gmail.com
Gerrit-Attention: Nicholas Chin nic.c3.14@gmail.com
Gerrit-Comment-Date: Thu, 19 Sep 2024 10:05:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes