Attention is currently required from: Tarun Tuli, Subrata Banik, Sridhar Siricilla.
Kapil Porwal has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/71687 )
Change subject: soc/intel: Add Kconfigs to define scaling factor for cores
......................................................................
Patch Set 1:
(2 comments)
File src/soc/intel/common/block/acpi/cpu_hybrid.c:
https://review.coreboot.org/c/coreboot/+/71687/comment/0a877cd6_98b6bd05
PS1, Line 78: soc_get_scaling_factor
Do we even need this function now?
https://review.coreboot.org/c/coreboot/+/71687/comment/4b645762_ec6f2abf
PS1, Line 79: scal_factor.performance_core
Can't we use `CONFIG_SOC_INTEL_PERF_CORE_SCAL_FACTOR`?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/71687
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I55e4d815116ef40c5f33be64ab495e942bf35ee8
Gerrit-Change-Number: 71687
Gerrit-PatchSet: 1
Gerrit-Owner: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tarun Tuli
taruntuli@google.com
Gerrit-Attention: Tarun Tuli
taruntuli@google.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Comment-Date: Thu, 05 Jan 2023 16:31:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment