Attention is currently required from: Felix Singer, Martin L Roth, Marvin Evers.
Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79439?usp=email )
Change subject: mb/google/poppy: Use chipset dt reference names ......................................................................
Patch Set 6:
(8 comments)
File src/mainboard/google/poppy/variants/atlas/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/79439/comment/e9191e11_bcb662e0 : PS6, Line 264: on tab
https://review.coreboot.org/c/coreboot/+/79439/comment/27c82e2b_e8dda5eb : PS6, Line 281: off end : device ref i2c2 on tab these out to match reset of file
https://review.coreboot.org/c/coreboot/+/79439/comment/c281c86a_5ff56387 : PS6, Line 301: device ref i2c4 on tab
https://review.coreboot.org/c/coreboot/+/79439/comment/8119ce66_1c3b6fd7 : PS6, Line 336: on tab
https://review.coreboot.org/c/coreboot/+/79439/comment/5c213066_871371d1 : PS6, Line 355: on tab
https://review.coreboot.org/c/coreboot/+/79439/comment/3ec0e95c_a95be12b : PS6, Line 367: on tab
File src/mainboard/google/poppy/variants/baseboard/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/79439/comment/03203530_2416ca81 : PS6, Line 254: o align all on/off entries one tab stop left of here
File src/mainboard/google/poppy/variants/nami/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/79439/comment/74992375_d996c922 : PS6, Line 286: on please use consistent tabbing of on/off throughout the file