build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46263 )
Change subject: nb/amd/pi/*/northbridge.c: Reduce difference ......................................................................
Patch Set 1:
(9 comments)
https://review.coreboot.org/c/coreboot/+/46263/1/src/northbridge/amd/pi/0063... File src/northbridge/amd/pi/00630F01/northbridge.c:
https://review.coreboot.org/c/coreboot/+/46263/1/src/northbridge/amd/pi/0063... PS1, Line 63: tempreg = (nodeid & 0xf) | ((nodeid & 0x30) << (8 - 4)) | (linkn << 4) | ((io_max & 0xf0)<<(12 - 4)); //limit line over 96 characters
https://review.coreboot.org/c/coreboot/+/46263/1/src/northbridge/amd/pi/0066... File src/northbridge/amd/pi/00660F01/northbridge.c:
https://review.coreboot.org/c/coreboot/+/46263/1/src/northbridge/amd/pi/0066... PS1, Line 163: for (link = 0; !res && (link < 8); link++) { braces {} are not necessary for single statement blocks
https://review.coreboot.org/c/coreboot/+/46263/1/src/northbridge/amd/pi/0066... PS1, Line 347: extern struct device *vga_pri; // the primary vga device, defined in device.c line over 96 characters
https://review.coreboot.org/c/coreboot/+/46263/1/src/northbridge/amd/pi/0066... PS1, Line 348: printk(BIOS_DEBUG, "VGA: vga_pri bus num = %d bus range [%d,%d]\n", vga_pri->bus->secondary, line over 96 characters
https://review.coreboot.org/c/coreboot/+/46263/1/src/northbridge/amd/pi/0066... PS1, Line 355: else else should follow close brace '}'
https://review.coreboot.org/c/coreboot/+/46263/1/src/northbridge/amd/pi/0073... File src/northbridge/amd/pi/00730F01/northbridge.c:
https://review.coreboot.org/c/coreboot/+/46263/1/src/northbridge/amd/pi/0073... PS1, Line 70: tempreg = (nodeid & 0xf) | ((nodeid & 0x30) << (8 - 4)) | (linkn << 4) | ((io_max & 0xf0)<<(12 - 4)); //limit line over 96 characters
https://review.coreboot.org/c/coreboot/+/46263/1/src/northbridge/amd/pi/0073... PS1, Line 371: extern struct device *vga_pri; // the primary vga device, defined in device.c line over 96 characters
https://review.coreboot.org/c/coreboot/+/46263/1/src/northbridge/amd/pi/0073... PS1, Line 372: printk(BIOS_DEBUG, "VGA: vga_pri bus num = %d bus range [%d,%d]\n", vga_pri->bus->secondary, line over 96 characters
https://review.coreboot.org/c/coreboot/+/46263/1/src/northbridge/amd/pi/0073... PS1, Line 379: else else should follow close brace '}'