[coreboot-gerrit] [M] Change in coreboot[master]: UNTESTED acpi: Add ECAM region below PNP0C02 device in SSDT

[Nico Huber (Code Review)]

Attention is currently required from: Angel Pons, Arthur Heymans, Jeff Daly, Lance Zhao, Matt DeVillier, Sean Rhodes, Tim Wawrzynczak, Vanessa Eusebio.

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75729?usp=email )

Change subject: UNTESTED acpi: Add ECAM region below PNP0C02 device in SSDT
......................................................................

Patch Set 3:

(1 comment)

File src/acpi/acpi.c:

https://review.coreboot.org/c/coreboot/+/75729/comment/8d08f99b_09a6e04d :
PS2, Line 587: 	struct device *dev = dev_find_path(NULL, DEVICE_PATH_DOMAIN);
             : 	assert(dev != NULL);
> > Anyway, a different thought: This is probably not the right place to decide […]

Hmmm, looks like we always set `.ops` for the domain? Technically, it's like
any other pointer in there. The difference is that the others are already
set (all 21 times). Even if it feels 21 lines too much, it would also feel
odd to handle this one pointer differently. Or maybe I misunderstand.

That dummy device you have in mind, could that be added by sconfig?
Runtime code seems overkill.