Attention is currently required from: Christian Walter, Elyes Haouas, Felix Singer, Martin L Roth, Martin Roth, Name of user not set #1005382, Naveen Iyer, Paul Menzel.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/82006?usp=email )
Change subject: Makefile.mk: Associate reproducible build to commit ID ......................................................................
Patch Set 7:
(3 comments)
File Makefile.mk:
https://review.coreboot.org/c/coreboot/+/82006/comment/e5c75454_04305592 : PS7, Line 28: KERNELVERSION := $(shell test -z "$$(git status --porcelain)" && git log --no-abbrev-commit -1 --format="format:%H" ) this does a similar thing as the case below, so it would probably be better to use that in that case too instead of sort-of reimplementing it. the check for the tree not being dirty could probably be integrated into that case and only be done in the BUILD_TIMELESS_WITH_GITREV case
https://review.coreboot.org/c/coreboot/+/82006/comment/15786882_7068a7e6 : PS7, Line 496: CPPFLAGS_common += -D__TIMELESS__ this also needs to be done in the BUILD_TIMELESS_WITH_GITREV case for the build to be reproducible; otherwise the asserts will still contain line numbers
File util/genbuild_h/genbuild_h.sh:
https://review.coreboot.org/c/coreboot/+/82006/comment/6fa6fdee_3e6de4fd : PS7, Line 37: H does %H vs %h make any difference? would probably be good to use the same as in the already existing case after this one