Attention is currently required from: Tim Wawrzynczak, Nick Vaccaro.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60415 )
Change subject: mb/google/volteer/var/collis: Add fw_config probe for ALC5682-VD & VS
......................................................................
Patch Set 3:
(1 comment)
File src/mainboard/google/volteer/variants/collis/variant.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136375):
https://review.coreboot.org/c/coreboot/+/60415/comment/82aa138a_1ab143bd
PS3, Line 20: }
adding a line without newline at end of file
--
To view, visit
https://review.coreboot.org/c/coreboot/+/60415
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia6089441dc1ba04c3f7427dda065b85bd295af0d
Gerrit-Change-Number: 60415
Gerrit-PatchSet: 3
Gerrit-Owner: Frank Chu
frank_chu@pegatron.corp-partner.google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Daniel Peng
daniel_peng@pegatron.corp-partner.google.com
Gerrit-CC: Hank Lin
hank2_lin@pegatron.corp-partner.google.com
Gerrit-CC: Ken Lu
ken_lu@pegatron.corp-partner.google.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Comment-Date: Tue, 28 Dec 2021 08:12:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment