Attention is currently required from: Krystian Hebel, Michał Kopeć, Michał Żygowski, Sergii Dmytruk.
Maximilian Brune has posted comments on this change by Krystian Hebel. ( https://review.coreboot.org/c/coreboot/+/82639?usp=email )
The change is no longer submittable: All-Comments-Resolved is unsatisfied now.
Change subject: mb/qemu-{i440fx,q35}: reduce default ROM size to 8 MiB
......................................................................
Patch Set 6:
(1 comment)
File src/mainboard/emulation/qemu-q35/Kconfig:
https://review.coreboot.org/c/coreboot/+/82639/comment/05bfc339_c55fe577?usp... :
PS6, Line 13: select BOARD_ROMSIZE_KB_8192
I regularly use QEMU-Q35 in combination with Linuxboot. 8MB is not enough space for that (at least not without serious effort).
As far as I understood it 16MB is still possible using the `max-fw-size` option and for the QEMU `-bios` option 16MB also works fine. So I would at least like to have a Kconfig option that lets me choose between 8MB and 16MB. I don't mind defaulting to 8MB though as long as I can set an option in my defconfig to keep using 16MB.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/82639?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: If36cb754a8e75e23bce49ff568dd88e5db279bb8
Gerrit-Change-Number: 82639
Gerrit-PatchSet: 6
Gerrit-Owner: Krystian Hebel
krystian.hebel@3mdeb.com
Gerrit-Reviewer: Maciej Pijanowski
maciej.pijanowski@3mdeb.com
Gerrit-Reviewer: Michał Kopeć
michal.kopec@3mdeb.com
Gerrit-Reviewer: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Sergii Dmytruk
sergii.dmytruk@3mdeb.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-Attention: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Attention: Michał Kopeć
michal.kopec@3mdeb.com
Gerrit-Attention: Krystian Hebel
krystian.hebel@3mdeb.com
Gerrit-Attention: Sergii Dmytruk
sergii.dmytruk@3mdeb.com
Gerrit-Comment-Date: Tue, 13 Aug 2024 18:34:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No