Martin Roth (martinroth@google.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/16606
-gerrit
commit ddbc8fb393ff8d614d662ec6d8b234dd56f16147 Author: Martin Roth martinroth@google.com Date: Wed Sep 14 18:11:01 2016 -0700
Build system: Remove IASL_WARNINGS_ARE_ERRORS option
All systems are building with IASL warnings as errors enabled. Remove the option to disable it.
Remove the notification at the end of the build.
Change-Id: I5c6218c182fdf173b4026fd010d939a5fa36040e Signed-off-by: Martin Roth martinroth@google.com --- Makefile.inc | 8 -------- 1 file changed, 8 deletions(-)
diff --git a/Makefile.inc b/Makefile.inc index 21b07e6..ee04db3 100644 --- a/Makefile.inc +++ b/Makefile.inc @@ -235,11 +235,7 @@ cbfs-files-$(if $(2),$(2),y) += $(CONFIG_CBFS_PREFIX)/$(1).aml $(obj)/$(1).aml: $(src)/mainboard/$(MAINBOARDDIR)/$(1).asl $(obj)/config.h @printf " IASL $$(subst $(top)/,,$$(@))\n" $(CC_ramstage) -x assembler-with-cpp -E -MMD -MT $$(@) $$(CPPFLAGS_ramstage) -D__ACPI__ -P -include $(src)/include/kconfig.h -I$(obj) -I$(src) -I$(src)/include -I$(src)/arch/$(ARCHDIR-$(ARCH-ramstage-y))/include -I$(src)/mainboard/$(MAINBOARDDIR) $$< -o $$@ -ifeq ($(CONFIG_IASL_WARNINGS_ARE_ERRORS),y) cd $$(dir $$@); $(IASL) -we -p $$(notdir $$@) $$(notdir $$@) -else - cd $$(dir $$@); $(IASL) -p $$(notdir $$@) $$(notdir $$@) -endif if [ -z "$$$$($(IASL) -d $$@ 2>&1 | grep 'ACPI Warning')" ]; then echo " IASL $$@ disassembled correctly."; true; else echo "Error: Could not correctly disassemble $$@"; $(IASL) -d $$@; false; fi endef
@@ -844,10 +840,6 @@ endif mv $@.tmp $@ @printf " CBFSPRINT $(subst $(obj)/,,$(@))\n\n" $(CBFSTOOL) $@ print -r $(subst $(spc),$(comma),$(all-regions)) -ifeq ($(CONFIG_IASL_WARNINGS_ARE_ERRORS),) - @printf "\n***** WARNING: IASL warnings as errors is disabled! *****\n" - @printf "***** Please fix the ASL for this platform. *****\n\n" -endif
cbfs-files-y += $(CONFIG_CBFS_PREFIX)/romstage $(CONFIG_CBFS_PREFIX)/romstage-file := $(objcbfs)/romstage.elf