Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31832 )
Change subject: mb/gigabyte/ga-h61ma-d3v: Add new mainboard as variant ......................................................................
Patch Set 2:
(3 comments)
Looks good
https://review.coreboot.org/#/c/31832/1/src/mainboard/gigabyte/ga-h61m-s2pv/... File src/mainboard/gigabyte/ga-h61m-s2pv/Kconfig:
https://review.coreboot.org/#/c/31832/1/src/mainboard/gigabyte/ga-h61m-s2pv/... PS1, Line 25: select NORTHBRIDGE_INTEL_SANDYBRIDGE if BOARD_GIGABYTE_GA_H61MA_D3V : select NORTHBRIDGE_INTEL_IVYBRIDGE if BOARD_GIGABYTE_GA_H61M_S2PV why this distinction? H61 is a sandybridge gen PCH?
https://review.coreboot.org/#/c/31832/1/src/mainboard/gigabyte/ga-h61m-s2pv/... File src/mainboard/gigabyte/ga-h61m-s2pv/hda_verb.c:
https://review.coreboot.org/#/c/31832/1/src/mainboard/gigabyte/ga-h61m-s2pv/... PS1, Line 6: * This program is free software; you can redistribute it and/or Link it in the variant dir?
https://review.coreboot.org/#/c/31832/2/src/mainboard/gigabyte/ga-h61m-s2pv/... File src/mainboard/gigabyte/ga-h61m-s2pv/romstage.c:
https://review.coreboot.org/#/c/31832/2/src/mainboard/gigabyte/ga-h61m-s2pv/... PS2, Line 66: CONFIG(BOARD_GIGABYTE_GA_H61M_S2PV) !CONFIG(NO_UART_ON_SUPERIO)