Attention is currently required from: Jason Glenesk, Raul Rangel, Marshall Dawson, Chris Wang, Patrick Huang, Felix Held.
Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52545 )
Change subject: src/soc/amd/picasso: Add HDMI 2.0 disable setting
......................................................................
Patch Set 11: Code-Review+2
(1 comment)
File src/soc/amd/picasso/chip.h:
https://review.coreboot.org/c/coreboot/+/52545/comment/a4192733_c985b337
PS11, Line 179: bit0~3: disable HDMI 2.0 DDI0~3
Could we add some #defines or an enum for this just to make it easier to understand?
#define DISABLE_HDIM2_DDI_0 BIT(0)
...
#define DISABLE_HDMI2_DDI_ALL BIT(0) | BIT(1) | BIT(2) | BIT(3)
Then in devicetree we can or them together or disable everything easily.
I'm fine if that's done in a follow-on commit so you can get this in.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/52545
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I383bfd04e01f5202db093105662344869e475746
Gerrit-Change-Number: 52545
Gerrit-PatchSet: 11
Gerrit-Owner: Patrick Huang
patrick.huang@amd.corp-partner.google.com
Gerrit-Reviewer: Chris Wang
chris.wang@amd.corp-partner.google.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: chris wang
Chris.Wang@amd.com
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Attention: Chris Wang
chris.wang@amd.corp-partner.google.com
Gerrit-Attention: Patrick Huang
patrick.huang@amd.corp-partner.google.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Thu, 22 Apr 2021 15:36:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment