Jonathan Zhang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40544 )
Change subject: soc/intel/xeon_sp/skx: use mem32 address space for PCIe mem64 assignment ......................................................................
Patch Set 1:
(2 comments)
While working on this, I made a mistake and got a different change ID. The comments are addressed in https://review.coreboot.org/c/coreboot/+/40577 instead. I am going to abandon this one.
https://review.coreboot.org/c/coreboot/+/40544/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/40544/1//COMMIT_MSG@14 PS1, Line 14: works
work
Done
https://review.coreboot.org/c/coreboot/+/40544/1/src/soc/intel/xeon_sp/skx/c... File src/soc/intel/xeon_sp/skx/chip.c:
https://review.coreboot.org/c/coreboot/+/40544/1/src/soc/intel/xeon_sp/skx/c... PS1, Line 61: n}
Does that belong into an earlier commit?
Done