Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41086 )
Change subject: SMM: Validate more user-provided pointers ......................................................................
Patch Set 15:
(4 comments)
https://review.coreboot.org/c/coreboot/+/41086/11//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/41086/11//COMMIT_MSG@9 PS11, Line 9: Migitate
Mitigate
see latest patchset
https://review.coreboot.org/c/coreboot/+/41086/15//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/41086/15//COMMIT_MSG@9 PS15, Line 9: Migitate Mitigate
https://review.coreboot.org/c/coreboot/+/41086/12/src/soc/intel/baytrail/smi... File src/soc/intel/baytrail/smihandler.c:
https://review.coreboot.org/c/coreboot/+/41086/12/src/soc/intel/baytrail/smi... PS12, Line 7: #include <commonlib/region.h>
Why? Same in couple other files.
It's for checking whether the pointer overlaps the SMRAM region, AFAIUI
https://review.coreboot.org/c/coreboot/+/41086/12/src/soc/intel/baytrail/smi... PS12, Line 337: break
should this return instead?
Definitely