Attention is currently required from: Paul Menzel, Angel Pons, Boris Mittelberg.
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56840 )
Change subject: mb/google/dedede: allow MKBP devices
......................................................................
Patch Set 5:
(1 comment)
File src/mainboard/google/dedede/variants/baseboard/include/baseboard/ec.h:
https://review.coreboot.org/c/coreboot/+/56840/comment/5def5734_db13ba9f
PS5, Line 73: EC_ENABLE_TBMC_DEVICE
Sorry about the late comment. But, is this still required if all the buttons and switches are now routed via MKBP?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/56840
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9d1f43e4dd56318af4c1d5f5c1c3a2c237a05c5f
Gerrit-Change-Number: 56840
Gerrit-PatchSet: 5
Gerrit-Owner: Boris Mittelberg
bmbm@google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Aseda Aboagye
aaboagye@google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Boris Mittelberg
bmbm@google.com
Gerrit-Comment-Date: Tue, 10 Aug 2021 22:29:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment