mikeb mikeb has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31308 )
Change subject: mainboard/emulation: disable DRIVERS_INTEL_WIFI by default ......................................................................
Patch Set 4:
(3 comments)
https://review.coreboot.org/#/c/31308/3//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/31308/3//COMMIT_MSG@7 PS3, Line 7: src/mainboard/emulation/Kconfig: disable DRIVERS_INTEL_WIFI by default
This is much too long. The src/ and /Kconfig can be droped without […]
Done.
https://review.coreboot.org/#/c/31308/3//COMMIT_MSG@11 PS3, Line 11: should work fine. So this driver option is not required and could be disabled.
It doesn't matter if it is physical. The driver in question is 95% […]
Done.
https://review.coreboot.org/#/c/31308/3/src/mainboard/emulation/Kconfig File src/mainboard/emulation/Kconfig:
https://review.coreboot.org/#/c/31308/3/src/mainboard/emulation/Kconfig@24 PS3, Line 24: default n
If I'd see this (without this change in mind), I'd probably want to clean […]
I updated the reasoning and also checked how much we win by disabling this config alone. Turned out it is 44476-43965 = 511 bytes = 1.2% for BOARD_EMULATION_QEMU_X86_I440FX