Attention is currently required from: Julius Werner, Martin L Roth, Nico Huber, Torsten Schenk.
Felix Singer has posted comments on this change by Torsten Schenk. ( https://review.coreboot.org/c/coreboot/+/83379?usp=email )
Change subject: Makefile: unexport CFLAGS
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
Where does the flag leak, exactly? I believe for the actual coreboot cross-compilation, nothing shou […]
The leak is in `payloads/libpayload/Makefile.payload`. If CFLAGS is present in the environment, then the CFLAGS variable from the Makefile will expand to it.
I think Torsten tried to build coreboot with the coreinfo payload.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/83379?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I5fe75095aec620ef1bcdb5506dc7d29e482697a1
Gerrit-Change-Number: 83379
Gerrit-PatchSet: 1
Gerrit-Owner: Torsten Schenk
Gerrit-Reviewer: Martin L Roth
gaumless@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-CC: Julius Werner
jwerner@chromium.org
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Torsten Schenk
Gerrit-Attention: Martin L Roth
gaumless@gmail.com
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Comment-Date: Wed, 10 Jul 2024 00:05:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org