[coreboot-gerrit] Change in ...coreboot[master]: soc/intel/cannonlake: set use of legacy 8254 timer

[Nico Huber (Code Review)]

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33512 )

Change subject: soc/intel/cannonlake: set use of legacy 8254 timer
......................................................................

Patch Set 1:

(2 comments)

Should be synchronized with coreboot code in `soc/intel/cannonlake/lpc.c`.
Or maybe drop the coreboot code. It seems redundant?

https://review.coreboot.org/#/c/33512/1/src/soc/intel/cannonlake/Kconfig 
File src/soc/intel/cannonlake/Kconfig:

https://review.coreboot.org/#/c/33512/1/src/soc/intel/cannonlake/Kconfig@320 
PS1, Line 320: (SOC_INTEL_COFFEELAKE || SOC_INTEL_WHISKEYLAKE)
What is different on CNL/CML?

https://review.coreboot.org/#/c/33512/1/src/soc/intel/cannonlake/fsp_params.... 
File src/soc/intel/cannonlake/fsp_params.c:

https://review.coreboot.org/#/c/33512/1/src/soc/intel/cannonlake/fsp_params.... 
PS1, Line 248: 	params->Enable8254ClockGating = CONFIG_USE_LEGACY_8254_TIMER;
Clock gating disables things...