Attention is currently required from: Anil Kumar K, Cliff Huang, Jérémy Compostella, Subrata Banik.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76762?usp=email )
Change subject: cbfstool: Add relocation support for EFI binaries
......................................................................
Patch Set 4:
(1 comment)
File src/commonlib/fsp_relocate.c:
https://review.coreboot.org/c/coreboot/+/76762/comment/c8ffb5d4_7617570d :
PS3, Line 284: return 0;
Excellent question: I could not find any reason why this function would return -1 on success but it […]
Thank you for the analysis. Split this change into a separate commit?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/76762?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5e98ffd1d864cf9ac675421471d888334d8ab28b
Gerrit-Change-Number: 76762
Gerrit-PatchSet: 4
Gerrit-Owner: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Reviewer: Anil Kumar K
anil.kumar.k@intel.com
Gerrit-Reviewer: Cliff Huang
cliff.huang@intel.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Anil Kumar K
anil.kumar.k@intel.com
Gerrit-Attention: Cliff Huang
cliff.huang@intel.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Comment-Date: Wed, 02 Aug 2023 06:30:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Jérémy Compostella
jeremy.compostella@intel.com
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Gerrit-MessageType: comment