Attention is currently required from: Paul Menzel, Julius Werner.
Shelley Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62003 )
Change subject: mb/google/herobrine: Add Gigadevice SPI Part
......................................................................
Patch Set 2:
(1 comment)
File src/mainboard/google/herobrine/Kconfig:
https://review.coreboot.org/c/coreboot/+/62003/comment/2619cd98_9fb74be1
PS1, Line 27: select SPI_FLASH_GIGADEVICE
Sorting/ordering the `SPI_FLASH_XDEVICE` entries might useful (in a parent commit maybe).
Please see CB:62017
--
To view, visit
https://review.coreboot.org/c/coreboot/+/62003
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I73dc695afb7aa2b32aa966070eb057c828073d47
Gerrit-Change-Number: 62003
Gerrit-PatchSet: 2
Gerrit-Owner: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Ravi Kumar Bokka
c_rbokka@qualcomm.corp-partner.google.com
Gerrit-CC: Sudheer Amrabadi
samrabad@codeaurora.org
Gerrit-CC: mturney mturney
mturney@codeaurora.org
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Comment-Date: Wed, 16 Feb 2022 07:37:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Gerrit-MessageType: comment