Attention is currently required from: Arthur Heymans, Kyösti Mälkki.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61891 )
Change subject: drivers/usb/ehci_debug.c: Fix building with clang
......................................................................
Patch Set 2:
(2 comments)
File src/drivers/usb/ehci_debug.c:
https://review.coreboot.org/c/coreboot/+/61891/comment/9dda3cd4_220ed8a5
PS1, Line 23: /* When selected, you can debug the connection of usbdebug dongle.
With CONFIG(DEBUG_CONSOLE_INIT), you can ....
Done
https://review.coreboot.org/c/coreboot/+/61891/comment/835199aa_b2beda43
PS1, Line 29: if (!dbgp_enabled()) \
I would rather have the printk() skipped entirely. […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/61891
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Icf5fd69fbf54b0d40bfdb17d1396d77dcb0a6060
Gerrit-Change-Number: 61891
Gerrit-PatchSet: 2
Gerrit-Owner: Arthur Heymans
arthur.heymans@9elements.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-CC: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Arthur Heymans
arthur.heymans@9elements.com
Gerrit-Attention: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Comment-Date: Wed, 23 Mar 2022 13:19:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-MessageType: comment