Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44652 )
Change subject: soc/amd/picasso: If psp_verstage is in RO, don't reset on error
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/44652/1/src/soc/amd/picasso/psp_ver...
File src/soc/amd/picasso/psp_verstage/psp_verstage.c:
https://review.coreboot.org/c/coreboot/+/44652/1/src/soc/amd/picasso/psp_ver...
PS1, Line 32: /* Continue booting from RO */
You should add the 'why' here from the commit description for fuller context.
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/44652
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ibb6794fefe9d482850ca31b1d3b0d145fcd8bb8f
Gerrit-Change-Number: 44652
Gerrit-PatchSet: 2
Gerrit-Owner: Martin Roth
martinroth@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Aaron Durbin
adurbin@chromium.org
Gerrit-Comment-Date: Mon, 24 Aug 2020 15:59:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Aaron Durbin
adurbin@chromium.org
Gerrit-MessageType: comment