Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46442 )
Change subject: mb/google/kukui: fix SKUID config for burnet/esche ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/46442/1/src/mainboard/google/kukui/... File src/mainboard/google/kukui/boardid.c:
https://review.coreboot.org/c/coreboot/+/46442/1/src/mainboard/google/kukui/... PS1, Line 99: if (CONFIG(BOARD_GOOGLE_BURNET)) { : cached_sku_id = (0x10 | get_adc_index(SKU_ID_CHANNEL)); : return cached_sku_id; : } : given Jacuzzi followers should not use need LCD module, I'd recommend changing this for all Jacuzzi:
uint32_t lcm_id = 0;
if (!CONFIG(BOARD_GOOGLE_JACUZZI_COMMON)) lcm_id = get_adc_index(LCM_ID_CHANNEL);
.... cached_sku_id = lcm_id << 4 | get_adc_index(SKU_ID_CHANNEL);
And please also change the burnet/esche model file to only do 0x0, 0x1 (not 0x10, 0x11).