Attention is currently required from: Hung-Te Lin, Jarried Lin, Yidi Lin, Yu-Ping Wu.
Paul Menzel has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/83987?usp=email )
Change subject: soc/mediatek: Add null check for info with error handling
......................................................................
Patch Set 1:
(2 comments)
File src/soc/mediatek/common/gpio.c:
https://review.coreboot.org/c/coreboot/+/83987/comment/02a3255c_96f6ac84?usp... :
PS1, Line 193: printk(BIOS_ERR, "Error: raw_id is out of range\n");
Include the GPIO id?
https://review.coreboot.org/c/coreboot/+/83987/comment/0bfdcedc_186f9c1a?usp... :
PS1, Line 193: printk(BIOS_ERR, "Error: raw_id is out of range\n");
Alternatively, the error could be printed in `get_gpio_driving_info()`?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/83987?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I5dffdb9f3e4e7e0d49209e6012893cd246948ee8
Gerrit-Change-Number: 83987
Gerrit-PatchSet: 1
Gerrit-Owner: Jarried Lin
jarried.lin@mediatek.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Yidi Lin
yidilin@google.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Hung-Te Lin
hungte@chromium.org
Gerrit-Attention: Jarried Lin
jarried.lin@mediatek.com
Gerrit-Attention: Yidi Lin
yidilin@google.com
Gerrit-Attention: Yu-Ping Wu
yupingso@google.com
Gerrit-Comment-Date: Tue, 20 Aug 2024 14:31:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No