Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45799 )
Change subject: mb/ocp/deltalake: Override smbios_fill_dimm_locator for type 17
......................................................................
Patch Set 8:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45799/5/src/mainboard/ocp/deltalake...
File src/mainboard/ocp/deltalake/ramstage.c:
https://review.coreboot.org/c/coreboot/+/45799/5/src/mainboard/ocp/deltalake...
PS5, Line 246: dimm_locator[dimm->channel_num]
Do you mean like A0, A1 ..,etc? I use the same location string definitions in UEFI BIOS (A0, B0 .. […]
No, what I'd like to avoid is the character array. The alphabet letters have consecutive numeric values in the ASCII table: http://www.asciitable.com/
So, (dimm->channel_num + 'A') is valid C. If `dimm->channel_num` is 1, the result will be 'B', and so on. Doing this eliminates the need for the `dimm_locator` array.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/45799
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I84531f9ee8bc76d9529aa983bc13e64f40c93138
Gerrit-Change-Number: 45799
Gerrit-PatchSet: 8
Gerrit-Owner: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Jingle Hsu
jingle_hsu@wiwynn.com
Gerrit-Reviewer: John Looney
john.looney@gmail.com
Gerrit-Reviewer: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Marc Jones
marc@marcjonesconsulting.com
Gerrit-Reviewer: Morgan Jang
Morgan_Jang@wiwynn.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 05 Oct 2020 09:13:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Johnny Lin
Johnny_Lin@wiwynn.com
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment