Attention is currently required from: Elyes Haouas, Felix Singer.
Maxim has posted comments on this change by Maxim. ( https://review.coreboot.org/c/coreboot/+/83107?usp=email )
Change subject: mb/asrock: Add Asrock Industrial IMB-1222 motherboard ......................................................................
Patch Set 17:
(8 comments)
Patchset:
PS16:
Please remove "duplicated" includes and include only what you use.
Removed
Patchset:
PS17: + some changes in the device tree (USB, PMC)
File src/mainboard/asrock/imb-1222/Kconfig:
https://review.coreboot.org/c/coreboot/+/83107/comment/07b8da82_0b50626c?usp... : PS16, Line 21: select INTEL_INT15
duplicated select, remove
Done
File src/mainboard/asrock/imb-1222/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/83107/comment/2b7dcf11_79b2d5d7?usp... : PS16, Line 6: .chipset_lockdown = CHIPSET_LOCKDOWN_COREBOOT,
This is the default. Please remove.
Done
https://review.coreboot.org/c/coreboot/+/83107/comment/061e2c8c_34c56ec1?usp... : PS16, Line 45: device cpu_cluster 0 on end
Already in chipset devicetree. Please remove.
Done
https://review.coreboot.org/c/coreboot/+/83107/comment/f6b48baf_7eb64ea6?usp... : PS16, Line 91: device ref heci1 on end
Same as in chipset devicetree, please remove.
Done
https://review.coreboot.org/c/coreboot/+/83107/comment/7b245261_2354ad90?usp... : PS16, Line 143: device ref fast_spi on end
Same as in chipset devicetree, please remove.
Done
File src/mainboard/asrock/imb-1222/fmap.fmd:
PS16:
Is there a reason for the custom fmap? It looks pretty much like a standard one.
Anyway, it doesn't work and I didn't understand why. Removed.