[coreboot-gerrit] [M] Change in coreboot[master]: soc/intel/: Store CSE firmware version into cbmem table

[Sridhar Siricilla (Code Review)]

Attention is currently required from: Tarun Tuli, Subrata Banik, Dinesh Gehlot.

Sridhar Siricilla has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74256 )

Change subject: soc/intel/: Store CSE firmware version into cbmem table
......................................................................

Patch Set 8:

(1 comment)

File src/soc/intel/common/block/cse/cse_lite.c:

https://review.coreboot.org/c/coreboot/+/74256/comment/16ca5284_b34ebe5b 
PS7, Line 1089: 
              : 	const struct cse_bp_entry *cse_bp = cse_get_bp_entry(RW, &cse_bp_info.bp_info);
              : 	struct cse_fw_partition_info *version;
              : 	version = cbmem_add(CBMEM_ID_CSE_PARTITION_VERSION, sizeof(*version));
              : 	version->cur_cse_fw_version.major = cse_bp->fw_ver.major;
              : 	version->cur_cse_fw_version.minor = cse_bp->fw_ver.minor;
              : 	version->cur_cse_fw_version.hotfix = cse_bp->fw_ver.hotfix;
              : 	version->cur_cse_fw_version.build = cse_bp->fw_ver.build;
              : }
              :
> > If coreboot refers the metadata (which is CBFS FS) for CSE Lite version, we can avoid adding store […]

I can ask our team to implement this. But, just for reference, you may check implementation @ cse_check_update_status()  (https://review.coreboot.org/c/coreboot/+/74256/7/src/soc/intel/common/block/...) once.