Attention is currently required from: Kevin Chiu, Tim Wawrzynczak, Nick Vaccaro. Shon Wang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59305 )
Change subject: mb/google/brya/var/vell: update gpio override ......................................................................
Patch Set 11:
(3 comments)
File src/mainboard/google/brya/variants/vell/gpio.c:
https://review.coreboot.org/c/coreboot/+/59305/comment/ce41bbb9_f4714012 PS8, Line 10: /* A6 : ESPI_ALERT1# ==> ESPI_ALERT1 */ : PAD_CFG_GPI(GPP_A6, NONE, DEEP),
I don't think we use ESPI Alert1 on chrome EC platforms?
Done
https://review.coreboot.org/c/coreboot/+/59305/comment/7e1c5d41_be55912d PS8, Line 17: /* B2 : VRALERT# ==> RGB_RST_ODL */ : PAD_CFG_GPI(GPP_B2, NONE, DEEP),
Is this used to reset something or to read the reset state? It is programmed as an input here, so I […]
This for RGB keyboard to reset
https://review.coreboot.org/c/coreboot/+/59305/comment/1d1decaf_49f71676 PS8, Line 151:
You probably want to consider having a romstage GPIO table too, for the SSD PERST# deassertion, e.g. […]
Done