Attention is currently required from: Dinesh Gehlot, Eric Lai, Nick Vaccaro, Subrata Banik, V Sowmya.
Paul Menzel has posted comments on this change by V Sowmya. ( https://review.coreboot.org/c/coreboot/+/83145?usp=email )
The change is no longer submittable: All-Comments-Resolved is unsatisfied now.
Change subject: mb/google/brya: Create a tereid variant ......................................................................
Patch Set 1:
(6 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/83145/comment/b7a87682_723187bb?usp... : PS1, Line 7: a Remove.
https://review.coreboot.org/c/coreboot/+/83145/comment/6f6a9843_e4259708?usp... : PS1, Line 9: Twinlake Twin Lake
https://review.coreboot.org/c/coreboot/+/83145/comment/9327d161_f593960b?usp... : PS1, Line 11: Twinlake Twin Lake
https://review.coreboot.org/c/coreboot/+/83145/comment/2b004cb1_28b3ce99?usp... : PS1, Line 9: This patch creates a new tereid variant, which is a Twinlake : platform. This variant uses Nivviks board mounted with the : Twinlake SOC and hence the plan is to reuse the existing : nivviks variant code. Please use 72 characters per line.
https://review.coreboot.org/c/coreboot/+/83145/comment/488a740b_9c1a8337?usp... : PS1, Line 15: TEST= Genearte Please remove the space after =.
https://review.coreboot.org/c/coreboot/+/83145/comment/55b9727e_1d6c667f?usp... : PS1, Line 15: Genearte Generate