Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35481 )
Change subject: soc/mediatek/mt8183: Handle memory test failure
......................................................................
Patch Set 49:
(1 comment)
https://review.coreboot.org/c/coreboot/+/35481/49//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/35481/49//COMMIT_MSG@11
PS49, Line 11: If partial calibration fails or the mem test following it
: fails, hang forever.
Why is that a good idea?
That means we have no any other ways to initialize DRAM (usually implies hardware failure). Instead of falling into reboot loop and drains out of battery, it seems better to just hang so user may notice that and send to RMA.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35481
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8e1d4f5bc7b45f45a8bfef74e86ec0ff6a556af4
Gerrit-Change-Number: 35481
Gerrit-PatchSet: 49
Gerrit-Owner: huayang duan
huayangduan@gmail.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: huayang duan
huayangduan@gmail.com
Gerrit-CC: Huayang Duan
huayang.duan@mediatek.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 14 Oct 2019 23:52:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-MessageType: comment