Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40645 )
Change subject: src/lib: Enable SPD_READ_BY_WORD by default
......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/40645/3//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/40645/3//COMMIT_MSG@10
PS3, Line 10: 68,613ns for each PAGE.
This is timestamp form cbmen -t...I think it is thousands separator. Unit is nano second. […]
For an SPD page in byte reads, 9000 bits 10us each would be 90ms. That would match the magnitude if that is a thousands separator and unit is microseconds.
You can check if overall cbmem -t record for entering payload makes sense in microseconds. If not, some scaling or timer frequency in coreboot runtime could be wrong.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/40645
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib68e830c25d95e8498eead155b2fa881b0ae0313
Gerrit-Change-Number: 40645
Gerrit-PatchSet: 3
Gerrit-Owner: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 24 Apr 2020 16:34:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Kyösti Mälkki
kyosti.malkki@gmail.com
Comment-In-Reply-To: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-MessageType: comment