Xi Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48261 )
Change subject: src/mediatek/mt8192: pass regulator function pointer to dram blob
......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/c/coreboot/+/48261/1/src/soc/mediatek/mt8192/inc...
File src/soc/mediatek/mt8192/include/soc/dramc_param.h:
https://review.coreboot.org/c/coreboot/+/48261/1/src/soc/mediatek/mt8192/inc...
PS1, Line 57: ptr
how about _cb for callback ?
Ack
https://review.coreboot.org/c/coreboot/+/48261/1/src/soc/mediatek/mt8192/inc...
PS1, Line 148: dram
how about remove dram_ prefix to shorten the naming ?
Ack
--
To view, visit
https://review.coreboot.org/c/coreboot/+/48261
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id44fe4d6c7a7448b63b400744cbc331055e94024
Gerrit-Change-Number: 48261
Gerrit-PatchSet: 2
Gerrit-Owner: Xi Chen
xixi.chen@mediatek.com
Gerrit-Reviewer: Cindy Ching
cindy.ching@mediatek.corp-partner.google.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Yidi Lin
yidi.lin@mediatek.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Thu, 03 Dec 2020 09:07:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Yidi Lin
yidi.lin@mediatek.corp-partner.google.com
Gerrit-MessageType: comment