Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43752 )
Change subject: mb/google/kukui: Add discrete LPDDR4X DDR table support for burnet/esche ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/43752/2/src/mainboard/google/kukui/... File src/mainboard/google/kukui/sdram_params/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/43752/2/src/mainboard/google/kukui/... PS2, Line 8: dram-params := Please indent properly and move 'sdram-params :=' to outside the ifeq block, e.g.,
sdram-params := ifeq ($(CONFIG_BOARD_GOOGLE_BURNET),y) sdram-params += ... else # Default memory table sdram-params += ... endif