Attention is currently required from: YH Lin, Tim Wawrzynczak, Zhuohao Lee, Felix Held.
Raihow Shi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62770 )
Change subject: mb/google/brask/variants/moli: set eMMC pin in bootblock
......................................................................
Patch Set 5:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/62770/comment/9033fa58_bd80976a
PS3, Line 9: 1.add eMMC enable pin in bootblock
: 2.set eMMC reset pin unable in bootblock
suggestion: […]
Ok,
The first question, we follow the setting in primus.
In primus, it deasserted reset pin in bootblock.
The second question,
the reson why controller be powered on with reset asserted can refer to https://review.coreboot.org/c/coreboot/+/62703
--
To view, visit
https://review.coreboot.org/c/coreboot/+/62770
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I924fcdadaae8ed29b50369a55bad00983cf6ba19
Gerrit-Change-Number: 62770
Gerrit-PatchSet: 5
Gerrit-Owner: Raihow Shi
raihow_shi@wistron.corp-partner.google.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: YH Lin
yueherngl@google.com
Gerrit-Reviewer: Zhuohao Lee
zhuohao@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: 9elements QA
hardwaretestrobot@gmail.com
Gerrit-CC: Anfernee Chen
anfernee_chen@wistron.corp-partner.google.com
Gerrit-CC: Ariel Fang
ariel_fang@wistron.corp-partner.google.com
Gerrit-CC: Casper Chang
casper_chang@wistron.corp-partner.google.com
Gerrit-CC: Malik Hsu
malik_hsu@wistron.com
Gerrit-CC: Mark Hsieh
mark_hsieh@wistron.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Peter Chi
peter_chi@wistron.corp-partner.google.com
Gerrit-CC: Scott Chao
scott_chao@wistron.corp-partner.google.com
Gerrit-CC: Terry Chen
terry_chen@wistron.corp-partner.google.com
Gerrit-CC: Will Tsai
will_tsai@wistron.corp-partner.google.com
Gerrit-CC: Zoey Wu
zoey_wu@wistron.corp-partner.google.com
Gerrit-Attention: YH Lin
yueherngl@google.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Zhuohao Lee
zhuohao@google.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Tue, 15 Mar 2022 02:52:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-MessageType: comment