Attention is currently required from: Christian Walter, Julius Werner, Jérémy Compostella, Krystian Hebel, Martin L Roth, Sergii Dmytruk.
Michał Żygowski has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69159?usp=email )
Change subject: security/tpm: make tis_probe() return tpm_family ......................................................................
Patch Set 24:
(6 comments)
Patchset:
PS24: I have a use case for the *_probe functions that will not need to assign the family to the argument
File src/drivers/crb/tis.c:
https://review.coreboot.org/c/coreboot/+/69159/comment/4590c159_c64cb039 : PS24, Line 58: *family = TPM_2; Please guard the assignment:
if (family) *family = TPM_2;
File src/drivers/i2c/tpm/cr50.c:
https://review.coreboot.org/c/coreboot/+/69159/comment/b9d158a6_6a01c573 : PS24, Line 430: *family = TPM_2; a/a
File src/drivers/i2c/tpm/tis_atmel.c:
https://review.coreboot.org/c/coreboot/+/69159/comment/1f2cc608_91e34696 : PS24, Line 121: *family = CONFIG(TPM1) ? TPM_1 : TPM_2; a/a
File src/drivers/i2c/tpm/tpm.c:
https://review.coreboot.org/c/coreboot/+/69159/comment/8c2c5bc9_66f63e11 : PS24, Line 474: *family = CONFIG(TPM1) ? TPM_1 : TPM_2; a/a
File src/drivers/spi/tpm/tis.c:
https://review.coreboot.org/c/coreboot/+/69159/comment/eae41b5b_84691ccd : PS24, Line 60: *family = TPM_2; a/a