Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43781 )
Change subject: soc/amd/picasso: don't apply unconfigured USB2 PHY tune parameters ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/43781/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/43781/1//COMMIT_MSG@11 PS1, Line 11: configured in the board's devicetree. Since all parameters being zero is
The default UPD values added in the FSP build process are certainly less wrong than setting all fiel […]
Defaults can change. I was just noting in my experience that the defaults are normally wrong because one doesn't know the right values for the implementation (board design). "less wrong" -> sometimes working -> flaky and hard to understand failures seems better than "nothing works" which leads to people performing the proper design tuning. That's my opinion, but we can go this route. It's fine by me.