Attention is currently required from: Jason Glenesk, Raul Rangel, Furquan Shaikh, Marshall Dawson.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58306 )
Change subject: [WIP] soc/amd/common/block/uart: implement read_resource
......................................................................
Patch Set 1:
(1 comment)
File src/soc/amd/picasso/uart.c:
https://review.coreboot.org/c/coreboot/+/58306/comment/483268db_a125d0f1
PS1, Line 110: new_resource
Can you use `mmio_resource` instead?
looks like that using mmio_resource should be the way to go. i'll push a new version maybe tomorrow
--
To view, visit
https://review.coreboot.org/c/coreboot/+/58306
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4ffddee3f5f4281aca98ddfcefa639dfb7a38dae
Gerrit-Change-Number: 58306
Gerrit-PatchSet: 1
Gerrit-Owner: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Comment-Date: Thu, 14 Oct 2021 01:25:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Raul Rangel
rrangel@chromium.org
Gerrit-MessageType: comment