Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35763 )
Change subject: soc/intel/skylake: rework and fix platform detection
......................................................................
Patch Set 7:
Patch Set 7:
(6 comments)
Looks like you are overdoing the original cosmetic change a bit?
Please explain the problem you are trying to fix before putting
any more work into it.
Patch set #5 looked rather good?
I did. Read the commit message ;)
Also, the platform detection now has been implemented in a more generic
way that will make it possible to move this (and coreboot-native PCIe
root port swapping, which is already being worked on) to the common
section and make it available for other platforms.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35763
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ida60f619308388adc180a5652908e5a947c17c0f
Gerrit-Change-Number: 35763
Gerrit-PatchSet: 7
Gerrit-Owner: Michael Niewöhner
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Michael Niewöhner
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 09 Oct 2019 14:21:56 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment