Attention is currently required from: Alexander Couzens, Christian Walter, Dinesh Gehlot, Eric Lai, Erik van den Bogaert, Evgeny Zinoviev, Felix Held, Frans Hendriks, Fred Reitberger, Jason Glenesk, Jayvik Desai, Jeremy Soller, Jonathon Hall, Kapil Porwal, Kevin Keijzer, Michael Niewöhner, Michał Kopeć, Michał Żygowski, Nicholas Chin, Nicholas Sudsgaard, Nick Vaccaro, Nico Huber, Patrick Rudolph, Piotr Król, Rishika Raj, Sean Rhodes, Stefan Ott, Subrata Banik, Tim Crawford.
Angel Pons has posted comments on this change by Nicholas Sudsgaard. ( https://review.coreboot.org/c/coreboot/+/80333?usp=email )
Change subject: device/azalia: Rework azalia verb tables
......................................................................
Patch Set 22:
(1 comment)
Patchset:
PS21:
There is probably some clever way to automatic at least some of this work. […]
I've done some serious refactoring in Sandy/Ivy Bridge native raminit in the past. Because RAM initialisation depends on so many factors (mainboard, CPU, DIMMs, temperature...), boot-testing will never catch all possible regressions. If I had done my changes in one go (like this commit), no one would be able to review it.
Instead of that, I decided to take on a different route: https://review.coreboot.org/q/hashtag:%22iosav-api" is what I ended up doing. It's a bit hard to follow, but my thought process is:
```
1. coreboot has reproducible builds, in the form of `make BUILD_TIMELESS=1`
2. changes to source code do not always result in changes to machine code
3. introducing and eliminating macros (if done right) will be reproducible
4. reviewing a reproducible change is easier (coreboot.rom does not change)
5. it is nearly impossible to review complex bulk changes to magic numbers
6. wrapping/unwrapping magic values using macros is typically reproducible
7. changing how these magic values are used is *NOT* reproducible, sadly
8. updating a macro definition is easier to review than bulk magic changes
9. using more commits has some overhead, but eases reviewing each commit
```
The result is a patch train that does the following (more or less):
```
1. wrap magic numbers (e.g. HDA verbs) in scaffolding macros, reproducible
2. update the implementation and the scaffolding macros, *NOT* reproducible
3. get rid of all the temporary scaffolding macros from code, reproducible
```
This way, non-reproducible changes can be pretty short (so easier to review), and huge changes are reproducible (knowing that the coreboot.rom is identical allows focusing on other aspects).
--
To view, visit
https://review.coreboot.org/c/coreboot/+/80333?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: If8b672e4fd800b34e5ba39fad174fcf1154b0a54
Gerrit-Change-Number: 80333
Gerrit-PatchSet: 22
Gerrit-Owner: Nicholas Sudsgaard
devel+coreboot@nsudsgaard.com
Gerrit-Reviewer: Alexander Couzens
lynxis@fe80.eu
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Dinesh Gehlot
digehlot@google.com
Gerrit-Reviewer: Eric Lai
ericllai@google.com
Gerrit-Reviewer: Erik van den Bogaert
ebogaert@eltan.com
Gerrit-Reviewer: Evgeny Zinoviev
me@ch1p.io
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Frans Hendriks
fhendriks@eltan.com
Gerrit-Reviewer: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Jayvik Desai
jayvik@google.com
Gerrit-Reviewer: Jeremy Soller
jeremy@system76.com
Gerrit-Reviewer: Jonathon Hall
jonathon.hall@puri.sm
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Kevin Keijzer
kevin@quietlife.nl
Gerrit-Reviewer: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Reviewer: Michał Kopeć
michal.kopec@3mdeb.com
Gerrit-Reviewer: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: Nicholas Chin
nic.c3.14@gmail.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Piotr Król
piotr.krol@3mdeb.com
Gerrit-Reviewer: Rishika Raj
rishikaraj@google.com
Gerrit-Reviewer: Sean Rhodes
sean@starlabs.systems
Gerrit-Reviewer: Stefan Ott
coreboot@desire.ch
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tim Crawford
tcrawford@system76.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-CC: Keith Hui
buurin@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Stefan Ott
coreboot@desire.ch
Gerrit-Attention: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Attention: Dinesh Gehlot
digehlot@google.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Attention: Nicholas Sudsgaard
devel+coreboot@nsudsgaard.com
Gerrit-Attention: Jonathon Hall
jonathon.hall@puri.sm
Gerrit-Attention: Piotr Król
piotr.krol@3mdeb.com
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Sean Rhodes
sean@starlabs.systems
Gerrit-Attention: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Michał Kopeć
michal.kopec@3mdeb.com
Gerrit-Attention: Christian Walter
christian.walter@9elements.com
Gerrit-Attention: Nicholas Chin
nic.c3.14@gmail.com
Gerrit-Attention: Alexander Couzens
lynxis@fe80.eu
Gerrit-Attention: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Attention: Eric Lai
ericllai@google.com
Gerrit-Attention: Rishika Raj
rishikaraj@google.com
Gerrit-Attention: Frans Hendriks
fhendriks@eltan.com
Gerrit-Attention: Jeremy Soller
jeremy@system76.com
Gerrit-Attention: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Attention: Erik van den Bogaert
ebogaert@eltan.com
Gerrit-Attention: Kevin Keijzer
kevin@quietlife.nl
Gerrit-Attention: Jayvik Desai
jayvik@google.com
Gerrit-Attention: Tim Crawford
tcrawford@system76.com
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Evgeny Zinoviev
me@ch1p.io
Gerrit-Comment-Date: Sat, 14 Sep 2024 15:19:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nicholas Sudsgaard
devel+coreboot@nsudsgaard.com
Comment-In-Reply-To: Nicholas Chin
nic.c3.14@gmail.com