Attention is currently required from: Patrick Rudolph, Simon Chou, Johnny Lin, Tim Chu.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/71968 )
Change subject: mb/intel: add ArcherCity CRB support
......................................................................
Patch Set 8:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/71968/comment/f20cec3b_a8776526
PS2, Line 9: Intel ArcherCity CRB is a dual socket CRB with Intel
: Sapphire Rapids Scalable Processor chipset. The chipset
: also includes EmmitsBurg PCH.
Hi Paul, From the coreboot tutorial as below link it requests the commit messsage shall be 80 charac […]
You cite an example, which is about the source code files, and not the commit message. (Also that is outdated.)
Anyway, cf `util/lint/checkpatch.pl`, and Ic9c686cb1a902259b18377b76b5c999e94660fed.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/71968
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic02634cd615e2245e394f10aad24b0430cf5cd17
Gerrit-Change-Number: 71968
Gerrit-PatchSet: 8
Gerrit-Owner: Simon Chou
simonchou@supermicro.com.tw
Gerrit-Reviewer: Tim Chu
Tim.Chu@quantatw.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-CC: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-CC: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Attention: Simon Chou
simonchou@supermicro.com.tw
Gerrit-Attention: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Attention: Tim Chu
Tim.Chu@quantatw.com
Gerrit-Comment-Date: Wed, 01 Feb 2023 06:48:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Simon Chou
simonchou@supermicro.com.tw
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Gerrit-MessageType: comment