Attention is currently required from: Maximilian Brune, Philipp Hug.
Felix Held has posted comments on this change by Maximilian Brune. ( https://review.coreboot.org/c/coreboot/+/83284?usp=email )
The change is no longer submittable: All-Comments-Resolved is unsatisfied now.
Change subject: arch/riscv: Allow adding OpenSBI as external blob
......................................................................
Patch Set 2:
(1 comment)
File src/arch/riscv/Kconfig:
https://review.coreboot.org/c/coreboot/+/83284/comment/45a11c34_3799e8ad?usp... :
PS2, Line 61: string
shouldn't this be a bool option?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/83284?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I6592ad90a254ca4ac9a6cee89404ad49274f0dea
Gerrit-Change-Number: 83284
Gerrit-PatchSet: 2
Gerrit-Owner: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-Reviewer: Philipp Hug
philipp@hug.cx
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: ron minnich
rminnich@gmail.com
Gerrit-CC: Felix Held
felix-coreboot@felixheld.de
Gerrit-Attention: Philipp Hug
philipp@hug.cx
Gerrit-Attention: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-Comment-Date: Sun, 11 Aug 2024 17:12:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No