Attention is currently required from: Matt DeVillier, Paul Menzel, Sean Rhodes.
Angel Pons has posted comments on this change by Sean Rhodes. ( https://review.coreboot.org/c/coreboot/+/81409?usp=email )
Change subject: i2c/drivers/generic: Add support for including a CDM ......................................................................
Patch Set 10: Code-Review+1
(3 comments)
File src/drivers/i2c/generic/chip.h:
https://review.coreboot.org/c/coreboot/+/81409/comment/7d478c2a_9bac85b6?usp... : PS10, Line 87: * 1: 90 Degrees : * 2: 270 Degrees : * 3: 180 Degress : * 4: 0 Degress : * 5: 90 Degrees (Inverted) : * 6: 270 Degrees (Inverted) : * 7: 180 Degress (Inverted) : * 8: 0 Degress (Inverted) ```suggestion * 1: 90 Degrees * 2: 270 Degrees * 3: 180 Degrees * 4: 0 Degrees * 5: 90 Degrees (Inverted) * 6: 270 Degrees (Inverted) * 7: 180 Degrees (Inverted) * 8: 0 Degrees (Inverted) ```
https://review.coreboot.org/c/coreboot/+/81409/comment/5234a7a1_da4c5398?usp... : PS10, Line 99: CDM_NOT_PRESENT = 0, ```suggestion CDM_NOT_PRESENT = 0, ```
File src/drivers/i2c/generic/generic.c:
https://review.coreboot.org/c/coreboot/+/81409/comment/f7bf2110_dd6b77dd?usp... : PS10, Line 169: config->cdm_index nit:
```suggestion if (config->cdm_index != CDM_NOT_PRESENT) { ```