Attention is currently required from: Bora Guvendik, Cliff Huang, Kyoung Il Kim, Subrata Banik.
Jérémy Compostella has posted comments on this change by Cliff Huang. ( https://review.coreboot.org/c/coreboot/+/85198?usp=email )
Change subject: drivers/intel/touch: Add driver for Intel Touch Controller and Devices ......................................................................
Patch Set 4:
(1 comment)
File src/drivers/intel/touch/touch.c:
https://review.coreboot.org/c/coreboot/+/85198/comment/cab62350_30715d61?usp... : PS2, Line 28: truct thc_hidi2c_info { : /* device I2C address */ : uint16_t dev_addr; : /* device connection speed */ : uint32_t connection_speed; : /* device address mode */ : uint8_t addr_mode; : /* Standard Mode (100 kbit/s) Serial Clock Line HIGH Period */ : uint32_t sm_scl_high_period; : /* Standard Mode (100 kbit/s) Serial Clock Line LOW Period */ : uint32_t sm_scl_low_period; : /* Standard Mode (100 kbit/s) Serial Data Line Transmit Hold Period*/ : uint32_t sm_sda_hold_tx_period; : /* Standard Mode (100 kbit/s) Serial Data Receive Hold Period */ : uint32_t sm_sda_hold_rx_period; : /* Fast Mode (400 kbit/s) Serial Clock Line HIGH Period */ : uint32_t fm_scl_high_period; : /* Fast Mode (400 kbit/s) Serial Clock Line LOW Period */ : uint32_t fm_scl_low_period; : /* Fast Mode (400 kbit/s) Serial Data Line Transmit Hold Period */ : uint32_t fm_sda_hold_tx_period; : /* Fast Mode (400 kbit/s) Serial Data Line Receive Hold Period */ : uint32_t fm_sda_hold_rx_period; : /* Maximum length (in ic_clk_cycles) of suppressed spikes in Std Mode, Fast : Mode, and Fast Mode Plus. */ : uint32_t suppressed_spikes_s_f_fp; : /* Fast Mode Plus (1Mbit/sec) Serial Clock Line HIGH Period */ : uint32_t fmp_scl_high_period; : /* Fast Mode Plus (1Mbit/sec) Serial Clock Line LOW Period */ : uint32_t fmp_scl_low_period; : /* Fast Mode Plus (1Mbit/sec) Serial Data Line Transmit HOLD Period */ : uint32_t fmp_sda_hold_tx_period; : /* Fast Mode Plus (1Mbit/sec) Serial Data Line Receive HOLD Period */ : uint32_t fmp_sda_hold_rx_period; : /* High Speed Mode Plus (3.4Mbits/sec) Serial Clock Line HIGH Period */ : uint32_t hm_scl_high_period; : /* High Speed Mode Plus (3.4Mbits/sec) Serial Clock Line LOW Period */ : uint32_t hm_scl_low_period; : /* High Speed Mode Plus (3.4Mbits/sec) Serial Data Line Transmit HOLD Period */ : uint32_t hm_sda_hold_tx_period; : /* High Speed Mode Plus (3.4Mbits/sec) Serial Data Line Receive HOLD Period */ : uint32_t hm_sda_hold_rx_period; : /* Maximum length (in ic_clk_cycles) of suppressed spikes in High Speed Mode */ : uint32_t suppressed_spikes_h_fp;
It looks like this data structure could be a simple sub data structure of `struct drivers_intel_touc […]
Done