Attention is currently required from: Rafael Send.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49672?usp=email )
Change subject: drivers/51nb/thunderbolt/thunderbolt.c: Init Alpine Ridge card ......................................................................
Patch Set 8:
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/49672/comment/152e4f9b_4b542faf : PS8, Line 9: Added new files (chip.h & thunderbolt.c) to initialize / unhide Alpine Ridge controllers on unsupported mainboards without the use of the TB_HEADER. Please reflow for 72 characters per line.
https://review.coreboot.org/c/coreboot/+/49672/comment/58d6eacb_9f7e6e72 : PS8, Line 9: Added Please use imperative mood.
Patchset:
PS8: Rafael, it’d be great if you addressed Angel’s comment and marked them as *Resolved* afterward. Hopefully the change-set can be submitted then.
File src/drivers/51nb/thunderbolt/thunderbolt.c:
https://review.coreboot.org/c/coreboot/+/49672/comment/05904c71_5df7e453 : PS8, Line 22: while ((pci_read_config16(dev, 0x548) & 0x1) != 1 && count < 5000) { : mdelay(1); : count++; : } : if (count == 5000) { : printk(BIOS_INFO, "Loop timed out waiting for bit change\n"); : } `src/include/timer.h` provides `wait_ms()`. Can that be used instead?