Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31978 )
Change subject: Move calls to quick_ram_check() before CBMEM init
......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/#/c/31978/4/src/include/lib.h
File src/include/lib.h:
https://review.coreboot.org/#/c/31978/4/src/include/lib.h@30
PS4, Line 30: void quick_ram_check_or_die(uintptr_t dst);
Add comment that this is just touching 32-bits of memory?
Also, only when memory location is uncacheable does this function do anything. I think that should be documented as well.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/31978
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I33d4153a5ce0908b8889517394afb46f1ca28f92
Gerrit-Change-Number: 31978
Gerrit-PatchSet: 4
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Alexander Couzens
lynxis@fe80.eu
Gerrit-Reviewer: Damien Zammit
damien@zamaudio.com
Gerrit-Reviewer: David Guckian
david.guckian@intel.com
Gerrit-Reviewer: Huang Jin
huang.jin@intel.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Thu, 21 Mar 2019 18:22:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment