Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35427 )
Change subject: mb/supermicro/x11: add x11ssm-f board
......................................................................
Patch Set 35: Code-Review+1
(2 comments)
we don't accept .tgz or "working" configs, just source code. With that fixed it's ready to be merged.
https://review.coreboot.org/c/coreboot/+/35427/35/src/mainboard/supermicro/x...
File src/mainboard/supermicro/x11-lga1151-series/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/35427/35/src/mainboard/supermicro/x...
PS35, Line 21: CPPFLAGS_common += -I$(src)/mainboard/$(MAINBOARDDIR)/include
not required
https://review.coreboot.org/c/coreboot/+/35427/35/src/mainboard/supermicro/x...
File src/mainboard/supermicro/x11-lga1151-series/mainboard.c:
https://review.coreboot.org/c/coreboot/+/35427/35/src/mainboard/supermicro/x...
PS35, Line 18: #include <mainboard.h>
include/mainboard.h
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35427
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I24e6f0f41a844652f88b562285b26beef311a2c9
Gerrit-Change-Number: 35427
Gerrit-PatchSet: 35
Gerrit-Owner: Michael Niewöhner
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Michael Niewöhner
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 26 Sep 2019 07:24:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment