20 May
2020
20 May
'20
7:38 p.m.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41561 )
Change subject: mb/asus/p2b: Enable hardware monitor access via ISA bus ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/41561/1/src/mainboard/asus/p2b/main... File src/mainboard/asus/p2b/mainboard.c:
https://review.coreboot.org/c/coreboot/+/41561/1/src/mainboard/asus/p2b/main... PS1, Line 22: 0x60
Yes I should, if it's OK to expand my scope for. (I need to edit i82371eb.h for this. […]
You can make two commits: one that adds register definitions to i82371eb.h, and then have this change use them
Don't worry, I will make sure to review both of them 😊
--
To view, visit https://review.coreboot.org/c/coreboot/+/41561
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iaed1df7230359e94c580c305f4769c8bb4f5fce0
Gerrit-Change-Number: 41561
Gerrit-PatchSet: 1
Gerrit-Owner: Keith Hui buurin@gmail.com
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 20 May 2020 17:38:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons th3fanbus@gmail.com
Comment-In-Reply-To: Keith Hui buurin@gmail.com
Gerrit-MessageType: comment