Attention is currently required from: Xi Chen, Xixi Chen.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74543 )
Change subject: vendorcode/mediatek/mt8192: Fix set but unused variables
......................................................................
Patch Set 2:
(1 comment)
File src/vendorcode/mediatek/mt8192/include/dramc_common.h:
https://review.coreboot.org/c/coreboot/+/74543/comment/1d3090cc_13a15012
PS2, Line 58: if (0)
one question, is this better?
I guess BIOS_NEVER already statically makes it optimized out.
So without the if (0) the binary size does increase, so I think this is a good way to handle it.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/74543
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic05a9819764c03184b54c4fc58dbe325fddeae10
Gerrit-Change-Number: 74543
Gerrit-PatchSet: 2
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Xi Chen
xixi.chen@mediatek.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Xixi Chen
xixi.chen@mediatek.corp-partner.google.com
Gerrit-Attention: Xi Chen
xixi.chen@mediatek.com
Gerrit-Attention: Xixi Chen
xixi.chen@mediatek.corp-partner.google.com
Gerrit-Comment-Date: Wed, 19 Apr 2023 11:26:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Comment-In-Reply-To: Xixi Chen
xixi.chen@mediatek.corp-partner.google.com
Gerrit-MessageType: comment